Allow Query.options to be None #6519
Conversation
Query.options may not have a value on a database created by 10.1.0
Codecov Report
@@ Coverage Diff @@
## master #6519 +/- ##
=======================================
Coverage 61.26% 61.26%
=======================================
Files 158 158
Lines 12889 12889
Branches 1755 1755
=======================================
Hits 7896 7896
Misses 4743 4743
Partials 250 250
|
Is that the correct PR number? Looking at that PR just now, it seems like it was closed without being merged. (?) |
|
Ah right, updated the PR |
Also bump minimum counter font size to 14
Thanks, that seems like the right one now. 😄 |
|
@eradman If you reckon this is ready to merge, then I'm happy to do so. 😄 |
|
This seems good in my testing. With this patch I have succussfuly upgraded Redash with queries created by 10.1.0 |
|
Appologies, somehow I managed to update this PR with the fix for the counter widget as well (#6521) We can revert this, or leave it as is and confirm that this fixes the problem |
|
Ahhh, damn. We've subsequently merged other PRs too, so not super clean to revert. Are you ok to check if the accidentally-included-fix does solve the counter widget problem? If it does, then we got lucky. 😁 If not though, then figuring out the proper fix for the counter widget issue (#6521) and getting it merged there is probably the right approach. Hopefully. 😄 |
* Allow Query.options to be None Query.options may not have a value on a database created by 10.1.0 * Ensure counter widget is not compressed in query preview tabs Also bump minimum counter font size to 14
Query.options may not have a value on a database created by 10.1.0
What type of PR is this?
Description
This incompatibility was introduced in #4797
How is this tested?