Build + push preview image only on master branch
#6507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidopetri
force-pushed
the
gpetri/build-only-on-master
branch
from
d576464 to
086f665
Compare
guidopetri
commented
Oct 7, 2023
| @@ -172,7 +181,7 @@ jobs: | |||
| - frontend-unit-tests | |||
| - frontend-e2e-tests | |||
| - build-skip-check | |||
| if: ${{ needs.build-skip-check.outputs.skip }} == false | |||
| if: needs.build-skip-check.outputs.skip == 'false' | |||
There was a problem hiding this comment.
Turns out we don't need the {{ }} jinja braces, and this is now actually filtering whereas it was not before.
|
@justinclift when you have a minute, mind giving this a look? |
Codecov Report
@@ Coverage Diff @@
## master #6507 +/- ##
=======================================
Coverage 61.10% 61.10%
=======================================
Files 158 158
Lines 12883 12883
Branches 1753 1753
=======================================
Hits 7872 7872
Misses 4765 4765
Partials 246 246 |
justinclift
reviewed
Oct 8, 2023
| if [[ "${{ vars.DOCKER_USER }}" == '' ]]; then | ||
| echo 'Docker user is empty. Skipping build+push' | ||
| echo skip=true >> "$GITHUB_OUTPUT" | ||
| elif [[ "${{ secrets.DOCKER_PASS }}" == '' ]]; then |
There was a problem hiding this comment.
Good idea. The extra messages will help us figure out what's going wrong, when something is not working right. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
The CI is trying to build + push the
previewtagged image on PRs, but we only want that to happen on themasterbranch. This change adds a condition to the CI step that runs the build+push, filtering for the ref to bemasteras a condition of the CI step being run.How is this tested?
Added a test commit that skips the e2e/unit tests (for faster iteration) and verified that the build+push CI step does not run on this PR.
Related Tickets & Documents
#6503 , #6505 , #6420