Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkg-config to the Docker image #6419

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Add pkg-config to the Docker image #6419

merged 1 commit into from
Sep 3, 2023

Conversation

justinclift
Copy link
Member

@justinclift justinclift commented Sep 3, 2023

What type of PR is this?

  • Bug Fix

Description

While investigating a different problem with our Docker builds, it turns out the MySQL client install doesn't always work.

Collecting mysqlclient<3.0,>=1.4 (from memsql==3.2.0)
#22 55.46   Downloading mysqlclient-2.2.0.tar.gz (89 kB)
#22 55.46      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 89.5/89.5 kB 131.2 MB/s eta 0:00:00
#22 55.49   Installing build dependencies: started
#22 57.66   Installing build dependencies: finished with status 'done'
#22 57.67   Getting requirements to build wheel: started
#22 57.87   Getting requirements to build wheel: finished with status 'error'
#22 57.88   error: subprocess-exited-with-error
#22 57.88   
#22 57.88   × Getting requirements to build wheel did not run successfully.
#22 57.88   │ exit code: 1
#22 57.88   ╰─> [24 lines of output]
#22 57.88       /bin/sh: 1: pkg-config: not found
#22 57.88       /bin/sh: 1: pkg-config: not found

Adding the pkg-config Ubuntu package seems to fix the problem.

How is this tested?

  • Manually

I've only tested the Docker build process with this, not the full CI tests. They should (in theory) all work unchanged however.

Without pkg-config the MySQL client install doesn't always work
@justinclift justinclift enabled auto-merge (squash) September 3, 2023 06:24
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #6419 (92fb29c) into master (ab71bde) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6419   +/-   ##
=======================================
  Coverage   60.87%   60.87%           
=======================================
  Files         155      155           
  Lines       12718    12718           
  Branches     1729     1729           
=======================================
  Hits         7742     7742           
  Misses       4747     4747           
  Partials      229      229           

@justinclift justinclift merged commit 2a2c90a into master Sep 3, 2023
15 checks passed
@justinclift justinclift deleted the pkgconfig_v1 branch September 3, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant