Fix Cypress not running in forked repos

[justinclift]

What type of PR is this?

• Bug Fix

Description

This PR allows the Cypress CI tests to run in forks, without any changes being needed. At the moment it's failing in forks due to the --record option always being applied, even though it only makes sense for our main getredash/redash repo.

How is this tested?

• Unit tests (pytest, jest)
• E2E Tests (Cypress)

[codecov]

Codecov Report

Merging #6413 (97fa5ba) into master (abe70ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6413   +/-   ##
=======================================
  Coverage   60.87%   60.87%           
=======================================
  Files         155      155           
  Lines       12718    12718           
  Branches     1729     1729           
=======================================
  Hits         7742     7742           
  Misses       4747     4747           
  Partials      229      229           

[justinclift]

@guidopetri @eradman @konnectr @snickerjp Anyone up for taking a look over this? It's a super simple PR. 😄

[snickerjp]

I think it is a very good way. 👍
In my repository, should CYPRESS_OPTIONS be set to blank?

[justinclift]

In my repository, should CYPRESS_OPTIONS be set to blank?

You don't need to. 😄

The existing code in this cypress.js file has this line:

if (GITHUB_REPOSITORY === "getredash/redash") {

So, this PR has the CYPRESS_OPTIONS line be blank unless the repository it's running on is getredash/redash. For that one specific repository, it sets the option line to --record.

The blank default value is what lets Cypress run on all other repositories, such as yours and mine. 😄

[snickerjp]

Cool! Thanks for the description.

[justinclift]

No worries at all. 😄