Added New Env variable for Unpublished queries #5867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidopetri
reviewed
Jul 15, 2023
docker-compose.yml
Outdated
| @@ -19,6 +19,7 @@ x-redash-environment: &redash-environment | |||
| REDASH_MAIL_SERVER: "email" | |||
| REDASH_ENFORCE_CSRF: "true" | |||
| REDASH_GUNICORN_TIMEOUT: 60 | |||
| REDASH_FEATURE_VIEW_UNPUBLISH_QUERIES: "false" | |||
There was a problem hiding this comment.
Could we switch the default to true to maintain the old behavior if nobody does additional changes?
guidopetri
reviewed
Jul 15, 2023
There was a problem hiding this comment.
Thanks for this change @adithyapathipaka ! Would you mind opening an accompanying PR modifying this file in the docs to document this new env var and its behavior?
Additionally, I'm rebasing this branch on master to run the CI.
|
Whoops, that looks like a merge commit instead. We can squash the commits later, heh :) |
guidopetri
added
Frontend
UX
Documentation
python
adithyapathipaka
force-pushed
the
conseal_unpubshlied_queries
branch
from
a5ba9db to
2ff8367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Added new Env Variable REDASH_FEATURE_VIEW_UNPUBLISH_QUERIES and updated include_drafts param to get value from REDASH_FEATURE_VIEW_UNPUBLISH_QUERIES
Truefor the include_draft param.REDASH_FEATURE_VIEW_UNPUBLISH_QUERIES(boolean) through which application can be configured to view unpublished queriesREDASH_FEATURE_VIEW_UNPUBLISH_QUERIESwill betrueand can be configure through tofalseby adding the variable to env file.Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)