-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expire schemas after 7 days #5112
Conversation
@rauchy thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
It sounds like this PR needs to resolve conflicts and test |
Codecov Report
@@ Coverage Diff @@
## master #5112 +/- ##
==========================================
+ Coverage 60.84% 60.87% +0.02%
==========================================
Files 155 155
Lines 12714 12715 +1
Branches 1728 1728
==========================================
+ Hits 7736 7740 +4
+ Misses 4750 4747 -3
Partials 228 228
|
for good it would be necessary to add a test |
@rauchy , thanks for the contribution :) |
What type of PR is this? (check all applicable)
Description
Schema keys get replaced only when they are refreshed. If refresh fails, or if data sources stop working - schemas would linger in Redis indefinitely.
This PR expires them 7 days after the next time they are supposedly scheduled to get refreshed. If they are refreshed by then - the TTL would slide 7 days into the future, otherwise they will expire.