Expire schemas after 7 days #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rauchy thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
|
It sounds like this PR needs to resolve conflicts and test |
konnectr
added
the
good first pr
Codecov Report
@@ Coverage Diff @@
## master #5112 +/- ##
==========================================
+ Coverage 60.84% 60.87% +0.02%
==========================================
Files 155 155
Lines 12714 12715 +1
Branches 1728 1728
==========================================
+ Hits 7736 7740 +4
+ Misses 4750 4747 -3
Partials 228 228
|
|
for good it would be necessary to add a test |
|
@rauchy , thanks for the contribution :) |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
* expire schemas after 7 days * expire schemas 7 days after the last refresh_schemas scheduled time * format files * add expire schema test * patch schema away * return nothing on schema get * fix redis key name * finally run tests locally and fix tests --------- Co-authored-by: Omer Lachish <[email protected]> Co-authored-by: Justin Clift <[email protected]> Co-authored-by: konnectr <[email protected]> Co-authored-by: Konstantin Smirnov <[email protected]> Co-authored-by: Guido Petri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Schema keys get replaced only when they are refreshed. If refresh fails, or if data sources stop working - schemas would linger in Redis indefinitely.
This PR expires them 7 days after the next time they are supposedly scheduled to get refreshed. If they are refreshed by then - the TTL would slide 7 days into the future, otherwise they will expire.