Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly filter apps based on their allowed access status #1290

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Properly filter apps based on their allowed access status #1290

merged 5 commits into from
Jan 20, 2025

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Jan 17, 2025

No description provided.

@atavism atavism requested a review from jigar-f January 17, 2025 23:11
atavism
atavism commented Jan 17, 2025
View reviewed changes
internalsdk/session_model.go
}
return strings.Join(strSlice, ","), nil

return strings.Join(allowedAccess, ","), nil
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jigar-f Looks like we were returning installed apps here instead of apps allowed access

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @atavism

@jigar-f
Copy link
Contributor

jigar-f commented Jan 20, 2025

LGTM!

@jigar-f jigar-f merged commit a2b3acd into main Jan 20, 2025
2 checks passed
@jigar-f jigar-f deleted the atavism/split-tunneling branch January 20, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigar-f jigar-f jigar-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atavism @jigar-f