Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shared site.contentType.php controller #6950

Merged

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 24, 2025

Description

Summary of changes

  • Allows content representation-specific site controllers, e.g. site.json.php
  • Either site.php or the more specific representation site controller get merged into any other controller, but never both

Reasoning

Allows to globally provide data to all controllers/templates that only a specific content type needs.

Additional context

  • Please review the unit tests closely if each configuration ends in the results you would expect as well.

Changelog

Enhancement

  • Support for content representation specific site controllers, e.g. site.rss.php

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the needs: discussion 🗣 Requires further discussion to proceed label Jan 24, 2025
@distantnative distantnative self-assigned this Jan 24, 2025
@distantnative distantnative added this to the 5.0.0-beta.3 milestone Jan 24, 2025
src/Cms/App.php Show resolved Hide resolved
tests/Cms/App/AppTest.php Show resolved Hide resolved
@distantnative distantnative marked this pull request as ready for review January 24, 2025 19:43
@distantnative distantnative requested a review from a team January 24, 2025 19:44
@distantnative distantnative removed the needs: discussion 🗣 Requires further discussion to proceed label Jan 29, 2025
@bastianallgeier bastianallgeier merged commit 15594eb into v5/develop Jan 30, 2025
12 checks passed
@bastianallgeier bastianallgeier deleted the v5/enhancement/controller-site-representation branch January 30, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants