Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test gethue #114

Merged
merged 146 commits into from
Jan 13, 2025
Merged

Test gethue #114

merged 146 commits into from
Jan 13, 2025

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Jan 13, 2025

What changes were proposed in this pull request?

  • Rebase

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
  • (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

nidhibhatg and others added 30 commits July 1, 2024 17:42
* [ui-metrics-test] Adding an additional test for the metrics Page

* Changing the names of metrics to actual names of the metrics present in the page

* Adding a metrics to the test that will be present and rendered

* Removing superfluous comments

* Correction for the mock api for the test
…Component to Metrics and create a separate directory for the admin pages (#3767)

* Renaming AlertComponent to GlobalAlert for maintaining consistency

* Creating new files for Metrics within admin  and renaming MetricsComponent to Metrics

* Removing MetricsComponent from js/apps

* There was some extra code from the metricsComponent that was mistakenly left during removing the metrics.mako code (a script). I am doing that cleanup also within a commit in this PR

* Adding the new test for the metrics

* There was some extra code from the metricsComponent that was mistakenly left during removing the metrics.mako code (a script). I am doing that cleanup also within a commit in this PR

* Renaming AlertComponent to GlobalAlert for maintaining consistency

* Creating new files for Metrics within admin  and renaming MetricsComponent to Metrics

* Removing MetricsComponent from js/apps

* There was some extra code from the metricsComponent that was mistakenly left during removing the metrics.mako code (a script). I am doing that cleanup also within a commit in this PR

* Adding the new test for the metrics

* There was some extra code from the metricsComponent that was mistakenly left during removing the metrics.mako code (a script). I am doing that cleanup also within a commit in this PR
This upgrades all the jest testing libraries to the latest possible versions. The primary reason was to provide a fix for CVE-2023-48631, a vulnerability with @adobe/css-tools which is a transient dependency of jest-jsdom.

- Updated snapshots due to improved format
- Moved console.log of editor v2 up to the app.js as it appears in the tests
- jest config updated for deprecated configs

Manual testing and unit test runs.
This updates the license checker to include BlueOak-1.0.0 as a valid license. The complete license text has also been added to NOTICE.txt.
Bumps [ws](https://github.com/websockets/ws) from 7.5.2 to 7.5.10.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.5.2...7.5.10)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…779)

* [ui-core]: refactor storage browser table component

* fix: handle empty folder edge case

* fix: lint
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ananya_Agarwal <[email protected]>
* [ui-storageBrowser]Implement storage browser table search
## What changes were proposed in this pull request?

- Earlier we added request package in ext-py3 because we had to remove `chardet` package dependency by manual code changes in the package due to its LGPL license.
- But now with latest version of request is already depending on [charset_normalizer](https://pypi.org/project/charset_normalizer/) which is MIT license based by default, so it makes sense to get rid of the old ext-py3 based requests package and only add single line latest request package requirement in `base_requirement.txt`.

## How was this patch tested?

- Manually
…other code improvements (#3782)

## What changes were proposed in this pull request?

- Set DEFAULT_HOME_PATH valuefor existing tests and ensure overall proper config reset. This will ensure these unit tests are not depending on local Hue config.
- Remove few REMOTE_STORAGE_HOME occurrences from code comments.
- Also improve file opening in the test file to use py3 specific method.
- Format code and fix linting

## How was this patch tested?

- Running existing unit tests.
…ar (#3784)

## What changes were proposed in this pull request?

- Earlier, the `Edit List...` tab was generation no UX value and clicking on it was redirecting to gethue docs connector page for non-connector setup scenarios.
- This change removes the `Edit List...` tab from the editor dropdown in the left navigation. The plan is to make the editor dropdown section clean and to only show the configured editors.

## How was this patch tested?

- Manually
Change-Id: I81aa8d3f66d130bb9a6f841d32034190ec09d3a5
A couple of syntax proposal plugins has been removed as they've been accepted and are now part of Babel preset env.
White space has been adjusted in some files as the default linting rules have changed with the newer versions.

Updated Vue linting rules have been ignored given that new development will be in React only.
This also applies the latest default style lint rules to our style files.
Based on the dnspython upstream commits

1. rthalley/dnspython@f66e25b
Upstream PR: rthalley/dnspython#1044

2. rthalley/dnspython@0ea5ad0
Upstream PR: rthalley/dnspython#1054

Change-Id: I20193e975a05a8206f8beba7e9be17f23594afcd
Fix adapted based on the upstream commit
eventlet/eventlet@51e3c49

Change-Id: I9fd35be09ebb11ed328aac32748ade71a5e34e88
## What changes were proposed in this pull request?

- Earlier, the node version in ubuntu was defaulting to v18 even after explicitly installing node v20.
- Using the dedication action simplifies it and makes sure node v20 is correctly installed.

## How was this patch tested?

- By validating all checks are passing and checking node version in py3 CI logs
ramprasadagarwal and others added 27 commits December 17, 2024 19:19
…914)

[ui-storagebrowser] refactor storage browser and folder structure
* [ui-storagebrowser] refactor browser actions

* moves create file and folder actions to separate folder

* fix fileChooser unintentional render

* revert extra merge changes
…ser (#3916)

* [ui-storagebrowser] integrates file upload components to storage browser

* revert extra changes
* [ui-storagebrowser] updates browser url while navigating

* adds condition to change url only when they are different
* [ui-storagebrowser] refreshes file stats when file is edited
* [ui-storagebrowser] adds and reads configs from .ini files

* removes show download button from global constants

* moves the storage browser config to separate group

* adds storage_browser key in config
…ed problems (#3923)

[security] Inline Js Fixes, Fixes File Browser Issues and other related problems (#3923)
* [ui-storagebrowser] fixes routing between multiple fileSystem

* fixes linting
…#3933)

* ui-storagebrwoser] avoids unwanted api calls for non-editable file

* fix mock for datetime

* fixes the getFileType return type

* fixes lowercasing
…ling (#3925)

* [ui-storagebrowser] refactor storage browser actions to separate file for scaling

* fixes the typo
* [ui-storagebrowser] adds delete action for files and folder
* [ui-storagebrowser] implements error handling

* makes error messages consistent

* fixes the error message and toaster
* [ui-storagebrowser] adds compress action

* fixes the naming convention
…exception issue (#3940)

- Improve sending error message in old notebook API decorator to fix json decode issue origination from the function used for Solr APIs.
django-babel has been out of maintenance for a while. We forked it
several years ago and have been updating it to support newer and newer
django versions. This commit brings the whole django-babel code into
our repo and makes it simpler to maintain it in future. This will also
allow us to make django upgrade changes in lock-step with the hue app.
Jira: CDPD-77746

Testing:
Manually tested and was also tested at customer end.
* [Trino] Update Trino integration guide in Hue

* remove concurrency flag

* remove links giving 403

---------

Co-authored-by: Harsh Gupta <[email protected]>
Stacktrace seen:

[07/Jan/2025 09:31:26 -0800] access       ERROR     admin - "POST /desktop/log_js_error HTTP/1.1" --- JS ERROR: {"msg":"Uncaught TypeError: lodash__WEBPACK_IMPORTED_MODULE_1___default.a.trimRight is not a function","url":"https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/hue-bundle-651ca10da11cbc8f75e8.2537e7eff7ba.js","line":74060,"column":139,"stack":"TypeError: lodash__WEBPACK_IMPORTED_MODULE_1___default.a.trimRight is not a function\n    at app (https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/hue-bundle-651ca10da11cbc8f75e8.2537e7eff7ba.js:74060:139)\n    at https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83803:52\n    at nextEnter (https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83627:7)\n    at https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83804:7\n    at nextEnter (https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83627:7)\n    at https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83804:7\n    at nextEnter (https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83627:7)\n    at https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83804:7\n    at nextEnter (https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83627:7)\n    at https://ccycloud-1.ni-717x-yq.root.comops.site:8889/static/desktop/js/bundles/hue/vendors~hue-chunk-651ca10da11cbc8f75e8.04f0b70fc23d.js:83804:7"}

Co-authored-by: [email protected] <[email protected]>
@agl29 agl29 merged commit 6e3d0d8 into master Jan 13, 2025
6 checks passed
@agl29 agl29 deleted the test_gethue branch January 13, 2025 08:21
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.