Skip to content

Commit

Permalink
Fix phoenix database and table names case sensitive (#3474)
Browse files Browse the repository at this point in the history
In phoenix database and table names are case sensitive, but in the sql_achlemy code we do upper() which is causing the tables not to be listed out.

Internal Jira: CDPD-61651
  • Loading branch information
quadoss authored Sep 29, 2023
1 parent cd0f6bf commit da79cb5
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions desktop/libs/notebook/src/notebook/connectors/sql_alchemy.py
Original file line number Diff line number Diff line change
Expand Up @@ -441,11 +441,6 @@ def close_session(self, session):

@query_error_handler
def autocomplete(self, snippet, database=None, table=None, column=None, nested=None, operation=None):
if snippet['type'] == 'phoenix':
if database:
database = database.upper()
if table:
table = table.upper()
engine = self._get_engine()
inspector = inspect(engine)

Expand Down

0 comments on commit da79cb5

Please sign in to comment.