fix: replace empty table name result in panic (go-gorm#5048)

* fix: replace empty name result in panic * fix: replace empty table name result in panic
getevo · Feb 8, 2022 · d222151 · d222151
1 parent 416c4d0
commit d222151
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/schema/naming.go b/schema/naming.go
@@ -120,7 +120,13 @@ func (ns NamingStrategy) toDBName(name string) string {
 	}
 
 	if ns.NameReplacer != nil {
-		name = ns.NameReplacer.Replace(name)
+		tmpName := ns.NameReplacer.Replace(name)
+
+		if tmpName == "" {
+			return name
+		}
+
+		name = tmpName
 	}
 
 	if ns.NoLowerCase {

diff --git a/schema/naming_test.go b/schema/naming_test.go
@@ -197,3 +197,14 @@ func TestFormatNameWithStringLongerThan64Characters(t *testing.T) {
 		t.Errorf("invalid formatted name generated, got %v", formattedName)
 	}
 }
+
+func TestReplaceEmptyTableName(t *testing.T) {
+	ns := NamingStrategy{
+		SingularTable: true,
+		NameReplacer:  strings.NewReplacer("Model", ""),
+	}
+	tableName := ns.TableName("Model")
+	if tableName != "Model" {
+		t.Errorf("invalid table name generated, got %v", tableName)
+	}
+}