Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion bug #2427

Closed
wants to merge 2 commits into from
Closed

Remove assertion bug #2427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd9bcd
Remove assertion bug
MG190202 Feb 27, 2024
519ce03
Resolve lint errors
MG190202 Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions dozer-sink-aerospike/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,8 @@ use aerospike_client_sys::{
as_val_val_reserve, as_vector, as_vector_increase_capacity, as_vector_init, AS_BATCH_WRITE,
AS_BIN_NAME_MAX_LEN,
};
use dozer_core::{
node::{PortHandle, Sink, SinkFactory},
DEFAULT_PORT_HANDLE,
};
use dozer_core::node::{PortHandle, Sink, SinkFactory};
pub const DEFAULT_PORT_HANDLE: u16 = 0xffff_u16;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the DEFAULT_PORT_HANDLE is being used at 3 other places too, should i remove its usage at other places also?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

use dozer_types::errors::internal::BoxedError;
use dozer_types::geo::{Coord, Point};
use dozer_types::ordered_float::OrderedFloat;
Expand Down Expand Up @@ -1190,7 +1188,6 @@ impl Sink for AerospikeSink {
}

fn process(&mut self, op: TableOperation) -> Result<(), BoxedError> {
debug_assert_eq!(op.port, DEFAULT_PORT_HANDLE);
self.sender.send(op)?;
Ok(())
}
Expand Down
Loading