Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce json memory #2214

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Reduce json memory #2214

merged 3 commits into from
Nov 8, 2023

Conversation

Jesse-Bakker
Copy link
Contributor

@Jesse-Bakker Jesse-Bakker commented Nov 7, 2023 •
edited by chubei
Loading

Tested on the Amazon Berkeley Objects (listings) dataset, loaded using mongodb. Memory usage decreased by 75%

@Jesse-Bakker Jesse-Bakker requested a review from chubei November 7, 2023 16:49
chubei
chubei reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@chubei chubei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I didn't check code under dozer-sql (wasn't familar enough with it). The only problem I saw is the Ord implementation.

dozer-types/src/types/field.rs Show resolved Hide resolved
dozer-types/Cargo.toml Show resolved Hide resolved
dozer-types/src/json_types.rs Outdated Show resolved Hide resolved
@Jesse-Bakker Jesse-Bakker added this pull request to the merge queue Nov 8, 2023
@Jesse-Bakker Jesse-Bakker removed this pull request from the merge queue due to a manual request Nov 8, 2023
@Jesse-Bakker
Use ijson to make json more compact in memory
d933b34
@Jesse-Bakker
Update to [email protected].
dce7602 
This allows for a custom bincode encoding for the `Field` type, which in
turn allows to encode Field::Json as msgpack. This is required because
bincode is not self-describing, which json requires.
@Jesse-Bakker
Temporarily silence clippy large_error_variant warning
cd011f9
@Jesse-Bakker Jesse-Bakker added this pull request to the merge queue Nov 8, 2023
Merged via the queue into getdozer:main with commit a12f3d0 Nov 8, 2023
4 checks passed
@Jesse-Bakker Jesse-Bakker deleted the ijson branch November 8, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chubei chubei chubei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jesse-Bakker @chubei