Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable SQL queries on cache endpoints #2196

Merged
merged 3 commits into from
Nov 18, 2023
Merged

feat: enable SQL queries on cache endpoints #2196

merged 3 commits into from
Nov 18, 2023

Conversation

abcpro1
Copy link
Contributor

@abcpro1 abcpro1 commented Oct 30, 2023 •
edited
Loading

  • Make host and port for the pgwire server configurable
  • Fix value conversions
    • Decimals
    • Date and time
  • Pushdown query optimization
    • Limit pushdown (Note, datafusion does not support offset pushdown; it pushes down OFFSET 10 LIMIT 10 as LIMIT 20
    • Projection pushdown (currently not supported by the cache query planner)
    • Predicate pushdown
  • Implement pg_catalog tables. Some Postgres GUI clients don't work without them.
  • Dozer Cloud integration
  • Enable web browsers to use SQL
    • REST /sql endpoint
  • Authentication

@abcpro1 abcpro1 force-pushed the sql-layer branch 3 times, most recently from a06b0bf to 9c85a98 Compare November 11, 2023 14:15
@abcpro1 abcpro1 force-pushed the sql-layer branch 3 times, most recently from eabf595 to b020d92 Compare November 16, 2023 18:03
@abcpro1 abcpro1 assigned abcpro1 and unassigned abcpro1 Nov 16, 2023
@abcpro1 abcpro1 marked this pull request as ready for review November 16, 2023 18:04
@abcpro1 abcpro1 requested a review from chubei November 17, 2023 08:18
chubei
chubei approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@chubei chubei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't carefully read the sql/datafusion and sql/pgwire implementation. Other parts look good!

@abcpro1 abcpro1 added this pull request to the merge queue Nov 18, 2023
Merged via the queue into getdozer:main with commit f373f17 Nov 18, 2023
4 checks passed
@abcpro1 abcpro1 deleted the sql-layer branch November 18, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chubei chubei chubei approved these changes

Assignees
No one assigned
Labels
doc-update-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abcpro1 @chubei