Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove redundant variable assign #2127

Merged
merged 2 commits into from
Oct 6, 2023
Merged

chore: Remove redundant variable assign #2127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e576e8
chore: Remove redundant variable assign
karolisg Oct 5, 2023
a3569cb
fix other clippy warnings
karolisg Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dozer-api/src/grpc/client_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ impl ApiServer {
} else {
unauthenticated_reflection_service = Some(reflection_service);
};
let health_service = health_service;

let mut auth_service = None;
let security = get_api_security(self.security.to_owned());
Expand Down
1 change: 0 additions & 1 deletion dozer-ingestion/src/connectors/object_store/connector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ impl<T: DozerObjectStore> Connector for ObjectStoreConnector<T> {
joinset.spawn(async move {
let mut csv_table = CsvTable::new(csv_config, config);
csv_table.update_state = state;
let table_info = table_info;
csv_table.watch(table_index, &table_info, sender).await?;
Ok::<_, ConnectorError>(())
});
Expand Down
4 changes: 2 additions & 2 deletions dozer-ingestion/src/connectors/snowflake/connection/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,13 @@ impl<'env> Client<'env> {
.map(|(name, (_, schema))| match schema {
Ok(mut schema) => {
let mut indexes = vec![];
keys.get(&name).map_or((), |columns| {
if let Some(columns) = keys.get(&name) {
schema.fields.iter().enumerate().for_each(|(idx, f)| {
if columns.contains(&f.name) {
indexes.push(idx);
}
});
});
}

let cdc_type = if indexes.is_empty() {
CdcType::Nothing
Expand Down