Reduce memory usage of min and max aggregators #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes use of the fact that the output value of the aggregator will always be of the same, predetermined type. Therefore, there is no use in storing the type of the output for every record in the state. `Field` is 32 bytes, whereas the most common types for the outputs (u64 and float) are 8 bytes. In those cases this changes saves about 3/4 of the memory.
snork-alt
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the fact that the output value of the aggregator will
always be of the same, predetermined type. Therefore, there is no use in
storing the type of the output for every record in the state.
Fieldis 32 bytes, whereas the most common types for the outputs (u64and float) are 8 bytes. In those cases this changes saves about 3/4 of
the memory.
MinValue and MaxValue require some more work, and are therefore not included
in this PR, but the same principle applies there.