Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Read rocksdb path from config #2111

Closed
wants to merge 1 commit into from
Closed

feat: Read rocksdb path from config #2111

wants to merge 1 commit into from

Conversation

karolisg
Copy link
Contributor

No description provided.

@Jesse-Bakker
Copy link
Contributor

Should we by default create the temp dir in the HomeDir? Otherwise, if you don't specify a location in the config, you don't get any of the benefits of using rocksdb, which can be quite a footgun for users

@karolisg karolisg closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chubei chubei Awaiting requested review from chubei

@Jesse-Bakker Jesse-Bakker Awaiting requested review from Jesse-Bakker

Assignees
No one assigned
Labels
doc-update-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karolisg @Jesse-Bakker