Inline FieldType array in RecordRefInner #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves a pointer per recordref, which can be a significant memory saving in the presence of many small records. This also makes the Arc containing RecordRefInner a thin pointer, saving some more memory if there are many references to a record.
chubei
approved these changes
Sep 28, 2023
Yeah, any pointer to a DST will become fat by including the object's size. That goes for references, raw pointers, but also smart pointers like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves a pointer per recordref, which can be a significant memory
saving in the presence of many small records. This also makes the Arc
containing RecordRefInner a thin pointer, saving some more memory if
there are many references to a record.