Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove stop application call when deleting application #2085

Merged
merged 3 commits into from
Sep 25, 2023
Merged

chore: Remove stop application call when deleting application #2085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daa0d36
chore: Remove stop application call when deleting application
karolisg Sep 25, 2023
88ef3b9
Remove stop app
karolisg Sep 25, 2023
15c0711
Fix clippy warnings
karolisg Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions dozer-cli/src/simple/cloud/deployer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use dozer_types::grpc_types::cloud::GetDeploymentStatusRequest;
use crate::cloud_app_context::CloudAppContext;
use dozer_types::grpc_types::cloud::DeployAppRequest;
use dozer_types::grpc_types::cloud::File;
use dozer_types::grpc_types::cloud::{Secret, StopRequest, StopResponse};
use dozer_types::grpc_types::cloud::Secret;
use dozer_types::log::{info, warn};

pub async fn deploy_app(
Expand Down Expand Up @@ -96,17 +96,3 @@ async fn print_progress(
}
Ok::<(), CloudError>(())
}

pub async fn stop_app(
client: &mut DozerCloudClient<TokenLayer>,
app_id: &str,
) -> Result<StopResponse, CloudError> {
let result = client
.stop_dozer(StopRequest {
app_id: app_id.to_string(),
})
.await?
.into_inner();

Ok(result)
}
5 changes: 1 addition & 4 deletions dozer-cli/src/simple/cloud_orchestrator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::errors::OrchestrationError::FailedToReadOrganisationName;
use crate::errors::{
map_tonic_error, CliError, CloudError, CloudLoginError, ConfigCombineError, OrchestrationError,
};
use crate::simple::cloud::deployer::{deploy_app, stop_app};
use crate::simple::cloud::deployer::deploy_app;
use crate::simple::cloud::login::CredentialInfo;
use crate::simple::cloud::monitor::monitor_app;
use crate::simple::token_layer::TokenLayer;
Expand Down Expand Up @@ -161,9 +161,6 @@ impl CloudOrchestrator for SimpleOrchestrator {
self.runtime.block_on(async move {
let mut client = get_cloud_client(&cloud, cloud_config).await?;

stop_app(&mut client, &app_id).await?;

// steps.start_next_step();
let delete_result = client
.delete_application(DeleteAppRequest {
app_id: app_id.clone(),
Expand Down