fix: snowflake regression #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcpro1
force-pushed
the
snowflake-fix2
branch
from
53d2b14 to
ac4069c
Compare
Start the query exec iterator to get a valid schema. The iterator is considered empty if the schema is `None`.
abcpro1
force-pushed
the
snowflake-fix2
branch
from
ac4069c to
d3f5feb
Compare
chubei
approved these changes
Sep 20, 2023
|
@chubei we need integration tests for snowflake. |
|
I remember we have integration tests. We do all the github action setup. Is it not working? |
|
There are no tests which name begins with |
|
@karolisg do you know what's happening with the snowflake tests? |
I remember we had problems setting credentials in github CI, so we disabled it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start the query exec iterator to get a valid schema. The iterator is considered empty if the schema is
None.