Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor cloud methods #2045

Merged
merged 5 commits into from
Sep 18, 2023
Merged

chore: refactor cloud methods #2045

merged 5 commits into from
Sep 18, 2023

Conversation

v3g42
Copy link
Contributor

@v3g42 v3g42 commented Sep 16, 2023

No description provided.

@v3g42 v3g42 requested a review from chubei September 17, 2023 19:57
Copy link
Contributor

@chubei chubei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, but I don't like that we don't have access to log stream on client side.

@v3g42 v3g42 marked this pull request as ready for review September 18, 2023 02:33
@v3g42
Copy link
Contributor Author

v3g42 commented Sep 18, 2023

PR looks good, but I don't like that we don't have access to log stream on client side.

I don't like it either. We will have to create a bit more infra for having. access to log stream between multiple servers.

This is a compromise for the time being.

@v3g42 v3g42 added this pull request to the merge queue Sep 18, 2023
@v3g42 v3g42 removed this pull request from the merge queue due to a manual request Sep 18, 2023
@v3g42 v3g42 merged commit e098ce0 into main Sep 18, 2023
5 checks passed
@v3g42 v3g42 deleted the chore/remove-auth-health branch September 18, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants