Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mysql use a random server_id if none was specified #2041

Merged
merged 1 commit into from
Sep 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dozer-ingestion/src/connectors/mysql/connector.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ use dozer_types::{
};
use mysql_async::{Opts, Pool};
use mysql_common::Row;
use rand::Rng;

#[derive(Debug)]
pub struct MySQLConnector {
Expand Down Expand Up @@ -378,7 +379,7 @@ impl MySQLConnector {
start_position: BinlogPosition,
stop_position: Option<BinlogPosition>,
) -> Result<(), ConnectorError> {
let server_id = self.server_id.unwrap_or(0xd07e5);
let server_id = self.server_id.unwrap_or_else(|| rand::thread_rng().gen());

let mut binlog_ingestor = BinlogIngestor::new(
ingestor,
Expand Down