Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Metrics api #2013

Merged
merged 14 commits into from
Sep 19, 2023
Merged

feat: Metrics api #2013

merged 14 commits into from
Sep 19, 2023

Conversation

mediuminvader
Copy link
Contributor

No description provided.

Copy link
Contributor

@chubei chubei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have to see the server counterpart to appropriately review this

@mediuminvader mediuminvader changed the title feat: Errors api feat: Prometheus api Sep 19, 2023
@mediuminvader mediuminvader changed the title feat: Prometheus api feat: Metrics api Sep 19, 2023
Copy link
Contributor

@chubei chubei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait for @karolisg to approve

@mediuminvader mediuminvader requested review from karolisg and removed request for karolisg September 19, 2023 07:16
@mediuminvader mediuminvader added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 770be3d Sep 19, 2023
6 checks passed
@mediuminvader mediuminvader deleted the feat-telemetry-api branch September 19, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants