feat: Add options to clickhouse client (#2465)

* feat: Add options to clickhouse client * fix test
getdozer · Mar 23, 2024 · 8d4a3c5 · 8d4a3c5
1 parent 9c13ed6
commit 8d4a3c5
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 1 deletion.
diff --git a/dozer-sink-clickhouse/src/client.rs b/dozer-sink-clickhouse/src/client.rs
@@ -30,8 +30,14 @@ impl ClickhouseClient {
             None => config.user.to_string(),
         };
 
+        let options = config
+            .options
+            .iter()
+            .map(|(k, v)| format!("{}={}", k, v))
+            .collect::<Vec<String>>()
+            .join("&");
         let url = format!(
-            "{}://{}@{}:{}/{}",
+            "{}://{}@{}:{}/{}?{options}",
             config.scheme, user_password, config.host, config.port, config.database
         );
         debug!("{url}");

diff --git a/dozer-sink-clickhouse/src/tests.rs b/dozer-sink-clickhouse/src/tests.rs
@@ -20,6 +20,7 @@ fn get_sink_config() -> ClickhouseSinkConfig {
         database: "default".to_string(),
         host: "localhost".to_string(),
         port: 9000,
+        options: vec![],
     }
 }
 

diff --git a/dozer-types/src/models/sink.rs b/dozer-types/src/models/sink.rs
@@ -200,6 +200,7 @@ pub struct ClickhouseSinkConfig {
     pub scheme: String,
     #[serde(default = "ClickhouseSinkConfig::default_database")]
     pub database: String,
+    pub options: Vec<(String, String)>,
     pub source_table_name: String,
     pub sink_table_name: String,
     pub create_table_options: Option<ClickhouseTableOptions>,

diff --git a/json_schemas/dozer.json b/json_schemas/dozer.json
@@ -409,6 +409,7 @@
     "ClickhouseSinkConfig": {
       "type": "object",
       "required": [
+        "options",
         "sink_table_name",
         "source_table_name"
       ],
@@ -431,6 +432,22 @@
           "default": "0.0.0.0",
           "type": "string"
         },
+        "options": {
+          "type": "array",
+          "items": {
+            "type": "array",
+            "items": [
+              {
+                "type": "string"
+              },
+              {
+                "type": "string"
+              }
+            ],
+            "maxItems": 2,
+            "minItems": 2
+          }
+        },
         "password": {
           "default": null,
           "type": [