Skip to content

Commit

Permalink
fix: mysql use a random server_id if none was specified (#2041)
Browse files Browse the repository at this point in the history
MySQL returns an error if two clients are using the same `server_id` concurrently.
  • Loading branch information
abcpro1 authored Sep 15, 2023
1 parent 820759b commit 5335286
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dozer-ingestion/src/connectors/mysql/connector.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ use dozer_types::{
};
use mysql_async::{Opts, Pool};
use mysql_common::Row;
use rand::Rng;

#[derive(Debug)]
pub struct MySQLConnector {
Expand Down Expand Up @@ -378,7 +379,7 @@ impl MySQLConnector {
start_position: BinlogPosition,
stop_position: Option<BinlogPosition>,
) -> Result<(), ConnectorError> {
let server_id = self.server_id.unwrap_or(0xd07e5);
let server_id = self.server_id.unwrap_or_else(|| rand::thread_rng().gen());

let mut binlog_ingestor = BinlogIngestor::new(
ingestor,
Expand Down

0 comments on commit 5335286

Please sign in to comment.