feat: Enable string types (#2475)

* feat: Use nvarchar2 * Use chars
getdozer · Apr 4, 2024 · 3642fdc · 3642fdc
1 parent 28f540c
commit 3642fdc
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/dozer-ingestion/oracle/src/connector/mapping.rs b/dozer-ingestion/oracle/src/connector/mapping.rs
@@ -52,7 +52,7 @@ fn map_data_type(
     } else {
         match data_type {
             "VARCHAR2" => Ok(FieldType::String),
-            "NVARCHAR2" => unimplemented!("convert NVARCHAR2 to String"),
+            "NVARCHAR2" => Ok(FieldType::String),
             "INTEGER" => Ok(FieldType::I128),
             "NUMBER" => match (precision, scale) {
                 (Some(precision), Some(0)) if precision <= 19 => Ok(FieldType::Int),
@@ -66,9 +66,9 @@ fn map_data_type(
             "RAW" => Ok(FieldType::Binary),
             "ROWID" => Ok(FieldType::String),
             "CHAR" => Ok(FieldType::String),
-            "NCHAR" => unimplemented!("convert NCHAR to String"),
+            "NCHAR" => Ok(FieldType::String),
             "CLOB" => Ok(FieldType::String),
-            "NCLOB" => unimplemented!("convert NCLOB to String"),
+            "NCLOB" => Ok(FieldType::String),
             "BLOB" => Ok(FieldType::Binary),
             other => Err(DataTypeError::UnsupportedDataType(other.to_string())),
         }?