fix: Don't call Storage::delete_objects with empty objects array (#…

…2010)

dozer-log/src/replication/persist.rs

@@ -68,7 +68,9 @@ pub async fn load_persisted_log_entries(
     }
 
     // Remove extra entries. These are persisted in the middle of a checkpointing, but the checkpointing didn't finish.
-    storage.delete_objects(to_remove).await?;
+    if !to_remove.is_empty() {
+        storage.delete_objects(to_remove).await?;
+    }
 
     // Check invariants.
     if let Some(first) = result.first() {

dozer-log/src/storage/local.rs

@@ -167,6 +167,10 @@ impl Storage for LocalStorage {
     }
 
     async fn delete_objects(&self, keys: Vec<String>) -> Result<(), Error> {
+        if keys.is_empty() {
+            return Err(Error::EmptyDeleteObjectsRequest);
+        }
+
         for key in keys {
             let path = self.get_path(&key).await?;
             tokio::fs::remove_file(&path)

dozer-log/src/storage/mod.rs

@@ -111,6 +111,8 @@ pub enum Error {
     NonUtf8Path(PathBuf),
     #[error("upload not found: key {key}, upload id {upload_id}")]
     UploadNotFound { key: String, upload_id: String },
+    #[error("empty delete objects request")]
+    EmptyDeleteObjectsRequest,
 }
 
 use dyn_clone::DynClone;