Add clear search button. #152
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |||||
| <span class="search-icon flaticon-musica-searcher" v-if="mode == 'product'"></span> | ||||||
| <span class="search-icon flaticon-supermarket-scanner" v-if="mode == 'scan'"></span> | ||||||
| <div class="search-type" v-hotkey="hotkeys"> | ||||||
| <button type="button" class="clear-button" v-if="serachInput != ''" @click="clearSearch">X</button> | ||||||
| <a href="#" :class="{ active: mode == 'product'}" @click.prevent="changeMode('product')">{{ __( 'Product', 'wepos' ) }}</a> | ||||||
| <a href="#" :class="{ active: mode == 'scan'}" @click.prevent="changeMode('scan')">{{ __( 'Scan', 'wepos' ) }}</a> | ||||||
| </div> | ||||||
|
|
@@ -155,6 +156,11 @@ export default { | |||||
| this.$refs.productSearch.blur(); | ||||||
| }, | ||||||
|
|
||||||
| clearSearch() { | ||||||
| this.searchClose(); | ||||||
| this.serachInput = ''; | ||||||
|
There was a problem hiding this comment. Correct the typo in the variable name. - this.serachInput = '';
+ this.searchInput = '';Committable suggestion
Suggested change
There was a problem hiding this comment. Dear reviewer, this is not a typo but the original variable name. There was a problem hiding this comment. @daviddaytw, thank you for the clarification. I have verified that 'serachInput' is consistently used throughout the Analysis chain |
||||||
| }, | ||||||
|
|
||||||
| onKeyDown() { | ||||||
| jQuery('.product-search-item.selected').next().children('a').focus(); | ||||||
| }, | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the typo in the variable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear reviewer, this is not a typo but the original variable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daviddaytw, thank you for clarifying the usage of the variable name 'serachInput'. I appreciate your prompt response and will respect the existing naming convention in your codebase. If there's anything else you need, feel free to let me know!