Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎯 fix: Translation on some pages were not working due to wrong text-domains #2503

Merged

Conversation

devAsadNur
Copy link
Member

@devAsadNur devAsadNur commented Jan 7, 2025

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

Changelog entry

fix: Translation on some pages were not working due to wrong text-domains

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

  • Localization Updates
    • Updated translation domain from 'dokan' to 'dokan-lite' across multiple admin components
    • Modified localization strings for various UI elements including buttons, labels, and error messages
    • Ensured consistent use of 'dokan-lite' text domain in admin interfaces

@devAsadNur devAsadNur added the In Progress The issues is being worked on label Jan 7, 2025
@devAsadNur devAsadNur self-assigned this Jan 7, 2025
Copy link
Contributor

coderabbitai bot commented Jan 7, 2025

Walkthrough

This pull request focuses on updating localization strings across multiple Vue components and PHP files in the Dokan Lite plugin. The primary change involves systematically replacing the text domain from 'dokan' to 'dokan-lite' in translation function calls. These modifications ensure consistent localization context across various admin-related components, including commission settings, withdraw logs, vendor management, and dummy data import interfaces, without altering the underlying functionality.

Changes

File Change Summary
assets/src/js/setup-wizard/commission/AdminCommission.vue Updated translation domain from 'dokan' to 'dokan-lite' for commission type labels
includes/Admin/WithdrawLogExporter.php Changed localization domain for 'ID' column from 'dokan' to 'dokan-lite'
src/admin/components/AddReverseWithdraw.vue Updated button and vendor selection text domain to 'dokan-lite'
src/admin/pages/DummyData.vue Modified error message localization domain to 'dokan-lite'
src/admin/pages/VendorSingle.vue Comprehensive update of localization strings to 'dokan-lite' domain
src/admin/pages/Withdraw.vue Updated error message translation domain to 'dokan-lite'

Possibly related PRs

Suggested Labels

Type: Enhancement, QA approved, :+1: Dev Review Done, Upcoming Release

Suggested Reviewers

  • mrabbani
  • shohag121

Poem

🐰 Localization's dance, a linguistic leap,
From 'dokan' to 'dokan-lite', translations creep
Strings whisper softly in their new domain
A rabbit's code-hop, precise and plain
Translations bloom with linguistic grace! 🌈


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 466f28a and 0eb25e0.

📒 Files selected for processing (6)
  • assets/src/js/setup-wizard/commission/AdminCommission.vue (1 hunks)
  • includes/Admin/WithdrawLogExporter.php (1 hunks)
  • src/admin/components/AddReverseWithdraw.vue (2 hunks)
  • src/admin/pages/DummyData.vue (2 hunks)
  • src/admin/pages/VendorSingle.vue (14 hunks)
  • src/admin/pages/Withdraw.vue (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • assets/src/js/setup-wizard/commission/AdminCommission.vue
  • src/admin/pages/VendorSingle.vue
  • src/admin/pages/Withdraw.vue
  • src/admin/components/AddReverseWithdraw.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: e2e_api tests
🔇 Additional comments (2)
includes/Admin/WithdrawLogExporter.php (1)

Line range hint 110-132: LGTM! Consistent text domain implementation.

The text domain has been correctly updated to 'dokan-lite' across all translatable strings in the column definitions, maintaining consistency throughout the exporter implementation.

src/admin/pages/DummyData.vue (1)

Line range hint 248-252: LGTM! Consistent error handling implementation.

The text domain has been correctly updated to 'dokan-lite' in both error handling scenarios, maintaining consistency throughout the component.

Also applies to: 373-377


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@devAsadNur devAsadNur added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval urgent and removed In Progress The issues is being worked on labels Jan 8, 2025
@devAsadNur devAsadNur requested a review from mrabbani January 8, 2025 04:19
@mrabbani mrabbani added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Jan 9, 2025
@StalinDurjo StalinDurjo added QA approved This PR is approved by the QA team and removed Needs: Testing This requires further testing labels Jan 9, 2025
@Aunshon Aunshon merged commit 9ae1575 into getdokan:develop Jan 9, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved This PR is approved by the QA team urgent 👍 Dev Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants