Error on approved refund request when empty Commission _dokan_additional_fee #4018 #2485
Conversation
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
includes/Commission/Settings/OrderItem.php (2)
74-75: The empty check fix looks good, but consider additional safety measures.The introduction of
$empty_safe_additional_flateffectively prevents the division by zero error when$additional_flatis empty. However, we should also guard against$item_totalbeing zero.Consider applying this enhanced version with additional safety checks:
- $empty_safe_additional_flat = empty( $additional_flat ) ? 0 : $additional_flat; - $additional_flat = ( $empty_safe_additional_flat / $item_total ) * $product_price; + $empty_safe_additional_flat = empty( $additional_flat ) ? 0 : (float) $additional_flat; + $additional_flat = $item_total > 0 + ? ( $empty_safe_additional_flat / $item_total ) * $product_price + : 0;
74-75: Consider extracting the calculation logic into a separate method.The commission calculation logic could be more maintainable if moved to a dedicated method.
Consider this refactor:
+ /** + * Calculate proportional additional fee for refund + * + * @param float|string $additional_flat + * @param float $item_total + * @param float $product_price + * + * @return float + */ + private function calculate_proportional_additional_fee($additional_flat, float $item_total, float $product_price): float { + if (empty($additional_flat) || $item_total <= 0) { + return 0.0; + } + return ((float) $additional_flat / $item_total) * $product_price; + } // In the get() method: - $empty_safe_additional_flat = empty( $additional_flat ) ? 0 : $additional_flat; - $additional_flat = ( $empty_safe_additional_flat / $item_total ) * $product_price; + $additional_flat = $this->calculate_proportional_additional_fee($additional_flat, (float) $item_total, $product_price);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
includes/Commission/Settings/OrderItem.php(1 hunks)
🔇 Additional comments (1)
includes/Commission/Settings/OrderItem.php (1)
74-75: Verify the fix across different refund scenarios.
While the fix addresses the empty commission fee case, we should verify it works correctly across various refund scenarios.
osmansufy
added
Needs: Dev Review
mrabbani
added
👍 Dev Review Done
Needs: Testing
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
dokan-lite/includes/Commission/Settings/OrderItem.php:74#2491How to test the changes in this Pull Request:
Changelog entry
Title
Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit
Summary by CodeRabbit