fix: args missing issue for reverse-withdrawal API endpoints

[pronob1010]

All Submissions:

• My code follow the WordPress' coding standards
• My code satisfies feature requirements
• My code is tested
• My code passes the PHPCS tests
• My code has proper inline documentation
• I've included related pull request(s) (optional)
• I've included developer documentation (optional)
• I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

• Full PR Link

Closes

• Closes # https://github.com/getdokan/plugin-internal-tasks/issues/116

How to test the changes in this Pull Request:

• Steps or issue link

Changelog entry

• Args missing issue *

Args are missing on reverse-withdrawal API endpoints.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

• Code is not following code style guidelines
• Bad naming: make sure you would understand your code if you read it a few months from now.
• KISS: Keep it simple, Sweetie (not stupid!).
• DRY: Don't Repeat Yourself.
• Code that is not readable: too many nested 'if's are a bad sign.
• Performance issues
• Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
• Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

• Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
• Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
• Readable — Will your future self be able to understand this change months down the road?
• Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

• New Features

  • Enhanced REST API clarity by specifying that no arguments are required for the /dummy-data/status and /dummy-data/clear endpoints.
  • Improved functionality of the /transaction-types and /stores endpoints by adding support for pagination and collection-related parameters.

• Bug Fixes

  • Maintained existing error handling and permission checks for all modified endpoints.

[coderabbitai]

Walkthrough

The changes involve updates to two REST API controllers: DummyDataController and ReverseWithdrawalController. In DummyDataController, the status and clear endpoints have been modified to explicitly define that no arguments are required. In ReverseWithdrawalController, the transaction-types and stores endpoints have been enhanced to include arguments that support pagination and collection parameters. The overall logic and functionality of the existing methods remain unchanged.

Changes

File	Change Summary
includes/REST/DummyDataController.php	Updated register_rest_route for status and clear endpoints to include 'args' => [].
includes/REST/ReverseWithdrawalController.php	Updated register_routes to add args parameter for /transaction-types and /stores endpoints using get_collection_params().

Suggested labels

QA approved, :+1: Dev Review Done, Upcoming Release

Suggested reviewers

• shohag121
• mrabbani

Poem

In the code where rabbits play,
New routes hop in, hip-hip-hooray!
With args set free, they dance and twirl,
Enhancing APIs in a joyful whirl.
So let’s celebrate this merry cheer,
For clearer paths are now quite near! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98d3958 and a89fb53.

📒 Files selected for processing (2)

• includes/REST/DummyDataController.php (2 hunks)
• includes/REST/ReverseWithdrawalController.php (2 hunks)

🔇 Additional comments (4)

includes/REST/ReverseWithdrawalController.php (2)

106-106: LGTM: Proper implementation of collection parameters

The addition of get_collection_params() for the transaction-types endpoint is correct and follows REST API best practices for collection endpoints.

---

118-118: LGTM: Consistent implementation of collection parameters

The addition of get_collection_params() for the stores endpoint maintains consistency with other collection endpoints in the codebase.

includes/REST/DummyDataController.php (2)

44-44: LGTM: Clear specification of no required arguments

The empty args array with the explanatory comment clearly indicates that this endpoint doesn't accept any parameters.

---

67-67: LGTM: Consistent specification of no required arguments

The empty args array implementation maintains consistency with the status endpoint and clearly indicates no parameters are needed.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.