Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification count added on vendor dashboard menu render #2195

Merged

Conversation

aihimel
Copy link
Contributor

@aihimel aihimel commented Mar 7, 2024

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

Changelog entry

Notification Count Showing

After editing menu with Vendor Dashboard Menu Manager Settings, notification count on Support and Return Request vendor dashboard menu will show accordingly.

Before Changes

Previously notification count were not shown on Support and Return Request vendor dashboard menu.

After Changes

After this PR, notification count will show on Support and Return Request vendor dashboard menu.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@aihimel aihimel self-assigned this Mar 7, 2024
@aihimel aihimel added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Mar 7, 2024
@aihimel aihimel requested a review from nurul-umbhiya March 7, 2024 08:21
@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Mar 7, 2024
@StalinDurjo StalinDurjo added QA In Progress and removed Needs: Testing This requires further testing labels Apr 3, 2024
@StalinDurjo StalinDurjo added QA approved This PR is approved by the QA team and removed QA In Progress labels Apr 3, 2024
@aihimel aihimel added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval and removed QA approved This PR is approved by the QA team 👍 Dev Review Done labels Apr 3, 2024
@mrabbani mrabbani added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Apr 3, 2024
@StalinDurjo StalinDurjo added QA In Progress QA approved This PR is approved by the QA team and removed Needs: Testing This requires further testing QA In Progress labels Apr 4, 2024
@shohag121 shohag121 merged commit 4ba9597 into getdokan:develop Apr 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOKAN PRO - New Menu Manager Settings - No notification (Number) on Support and Refund Menu Items Tab anymore
6 participants