Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short form of days added for delivery time module #1989

Conversation

aihimel
Copy link
Contributor

@aihimel aihimel commented Sep 4, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Closes

How to test the changes in this Pull Request:

Changelog entry

Short from of weekdays added at dokan_get_translated_days function.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@aihimel aihimel self-assigned this Sep 4, 2023
@aihimel aihimel added Needs: Dev Review It requires a developer review and approval Needs: Testing This requires further testing labels Sep 4, 2023
@aihimel aihimel removed the request for review from Aunshon September 4, 2023 04:05
@devAsadNur devAsadNur added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Sep 4, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress Needs: Testing This requires further testing and removed Needs: Testing This requires further testing QA In Progress labels Sep 25, 2023
@aihimel aihimel added Needs: Testing This requires further testing and removed Type: Bug labels Oct 17, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress QA approved This PR is approved by the QA team and removed Needs: Testing This requires further testing QA In Progress labels Oct 26, 2023
@nurul-umbhiya nurul-umbhiya merged commit b04023c into getdokan:develop Nov 21, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved This PR is approved by the QA team 👍 Dev Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants