Merge pull request #10 from getcft/release-1.2

Removing Redundant DependsOn Reference
getcft · May 23, 2024 · 1ca317f · 1ca317f
2 parents 70041a7 + a10e5b3
commit 1ca317f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/.github/workflows/cloudformation-validation.yml b/.github/workflows/cloudformation-validation.yml
@@ -15,12 +15,14 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: CloudFormation-Validation
+      - name: CloudFormation Template Validation
         run: |
           pip install awscli
-          pip install cfn-lint
           aws cloudformation validate-template --template-body file://2-zone-vpc-cf-template.yml --region us-east-1
-          cfn-lint 2-zone-vpc-cf-template.yml
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+      - name: CloudFormation Linter
+        run: |
+          pip install cfn-lint
+          cfn-lint -I 2-zone-vpc-cf-template.yml
diff --git a/2-zone-vpc-cf-template.yml b/2-zone-vpc-cf-template.yml
@@ -191,8 +191,6 @@ Resources:
                       Ref: 'Environment'
 
     RoutePublicZoneA:
-        DependsOn:
-            - InternetGateway
         Type: AWS::EC2::Route
         Properties:
             DestinationCidrBlock: '0.0.0.0/0'
@@ -202,8 +200,6 @@ Resources:
                 Ref: 'RouteTablePublicZoneA'
 
     RoutePublicZoneB:
-        DependsOn:
-            - InternetGateway
         Type: AWS::EC2::Route
         Properties:
             DestinationCidrBlock: 0.0.0.0/0