chore: log relay errors only once per app #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Dec 20, 2024
| continue | ||
| } | ||
|
|
||
| sub, err := relay.Subscribe(ctx, []nostr.Filter{*filter}) | ||
| if err != nil { | ||
| // TODO: notify user about subscription failure |
There was a problem hiding this comment.
I think we should still log an error here, shouldn't we?
There was a problem hiding this comment.
This error never happened (in absolute terms), that's why I was confident of it, but doesn't hurt to log, should Ii add it back?
rolznz
reviewed
Dec 20, 2024
| @@ -713,7 +713,6 @@ func (svc *Service) startSubscription(ctx context.Context, subscription *Subscri | |||
| var relay *nostr.Relay | |||
| var isCustomRelay bool | |||
| var err error | |||
| waitToReconnectSeconds := 0 | |||
There was a problem hiding this comment.
A few lines down (line 726) we cancel the subscription and return if there is an error. I think we should only exit this loop when the context.Done channel receives a message, and we should handle it in one place like we do in Alby Hub.
rolznz
reviewed
Dec 20, 2024
| if err == nil { | ||
| svc.Relay = relay | ||
| } | ||
| return svc.Relay, false, err | ||
| } | ||
| } | ||
|
|
||
| func (svc *Service) relayConnectWithBackoff(ctx context.Context, relayURL string) (relay *nostr.Relay, err error) { |
|
The feedback here is noted, and will be addressed in a PR which aims to separate one-off subscriptions (as both comments refer to code in |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we only log once instead of per subscription which bloats DD