Skip to content

Commit

Permalink
Document skipping JDK enforcement
Browse files Browse the repository at this point in the history
- single profile to cover JDK9+

Signed-off-by: Gera Shegalov <[email protected]>
  • Loading branch information
gerashegalov committed Oct 28, 2023
1 parent 2cba130 commit 0ea0357
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,9 @@ mvn clean verify -Dbuildver=330 -P<jdk11|jdk17>
If you omit `-PjdkXY` the corresponding JDK profile will be activated implicitly based on the
detected JDK version executing the Maven build.
If you need to build with a JDK version that we do not test internally add
`-Denforcer.skipRules=requireJavaVersion` to the Maven invocation.
### Building and Testing with ARM
To build our project on ARM platform, please add `-Parm64` to your Maven commands.
Expand Down
6 changes: 4 additions & 2 deletions jdk-profiles/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,23 @@
<artifactId>rapids-4-spark-parent_2.12</artifactId>
<version>23.12.0-SNAPSHOT</version>
</parent>
<groupId>com.nvidia</groupId>
<artifactId>rapids-4-spark-jdk-profiles_2.12</artifactId>
<packaging>pom</packaging>
<description>Shim JDK Profiles</description>
<version>23.12.0-SNAPSHOT</version>
<profiles>
<profile>
<id>jdk11plus</id>
<id>jdk9plus</id>
<properties>
<scala.plugin.version>4.6.1</scala.plugin.version>
<maven.compiler.source>${java.specification.version}</maven.compiler.source>
<maven.compiler.release>${maven.compiler.source}</maven.compiler.release>
<maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
</properties>
<activation>
<jdk>[11,17]</jdk>
<!-- activate for all java versions after 9 -->
<jdk>[9,)</jdk>
</activation>
</profile>
</profiles>
Expand Down
6 changes: 4 additions & 2 deletions scala2.13/jdk-profiles/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,23 @@
<artifactId>rapids-4-spark-parent_2.13</artifactId>
<version>23.12.0-SNAPSHOT</version>
</parent>
<groupId>com.nvidia</groupId>
<artifactId>rapids-4-spark-jdk-profiles_2.13</artifactId>
<packaging>pom</packaging>
<description>Shim JDK Profiles</description>
<version>23.12.0-SNAPSHOT</version>
<profiles>
<profile>
<id>jdk11plus</id>
<id>jdk9plus</id>
<properties>
<scala.plugin.version>4.6.1</scala.plugin.version>
<maven.compiler.source>${java.specification.version}</maven.compiler.source>
<maven.compiler.release>${maven.compiler.source}</maven.compiler.release>
<maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
</properties>
<activation>
<jdk>[11,17]</jdk>
<!-- activate for all java versions after 9 -->
<jdk>[9,)</jdk>
</activation>
</profile>
</profiles>
Expand Down

0 comments on commit 0ea0357

Please sign in to comment.