Fix inconcistencies with caching GeoServer config infos #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify `CachingGeoServerFacade` making it evict the whole in-memory cache upon each change or incoming event. Trying to maintain too much logic to optimize per-object caching, specially for workspace `ServiceInfo` and `SettingsInfo` is too error prone and a maintenance burden. Evicting the config cache is not a problem while changes are being performed, and during normal operation with no config changes it just serves its purpose.
groldan
force-pushed
the
simplify_cachinggeoserverfacade
branch
from
858f283
to
0fedb83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
CachingGeoServerFacademaking it evict the whole in-memory cache upon each change or incoming event.Trying to maintain too much logic to optimize per-object caching, specially for workspace
ServiceInfoandSettingsInfois too error prone and a maintenance burden.Evicting the config cache is not a problem while changes are being performed, and during normal operation with no config changes it just serves its purpose.