Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build improvements #547

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

groldan
Copy link
Member

@groldan groldan commented Oct 12, 2024

  • Parameterize the docker "repository" for the dev compose
  • Replace JAVA_TOOL_OPTS by the more standard JAVA_TOOL_OPTIONS env variable
  • Add --add-opens=java.desktop/sun.java2d.pipe=ALL-UNNAMED to base image
    Allows to show the current rendering engine in the webui's server status page

@groldan groldan force-pushed the build/docker_java_tool_options branch 4 times, most recently from dc44976 to 88dbc42 Compare October 15, 2024 00:40
Allow to test locally by pushing/pulling to/from another account, e.g.:

```
REPOSITORY=groldan make build-multiplatform-image
```

will tag and push images as `groldan/xxx:<version>`
@groldan groldan force-pushed the build/docker_java_tool_options branch 4 times, most recently from 304bfa5 to 26d2c9d Compare October 15, 2024 02:18
Regularly, you'd keep on running `make
acceptance-tests-[datadir|pgconfig|jdbcconfig]` as usual.

For the github action it's nicer to have the docker compo start and run
in separte steps.
@groldan groldan force-pushed the build/docker_java_tool_options branch from 26d2c9d to d9394b9 Compare October 15, 2024 02:37
@groldan groldan added build Issues related to the build and/or CI docker Issues related to docker images or docker composition labels Oct 15, 2024
@groldan groldan merged commit e21ab17 into geoserver:main Oct 15, 2024
3 checks passed
@groldan groldan deleted the build/docker_java_tool_options branch October 15, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build and/or CI docker Issues related to docker images or docker composition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant