gwc - cleaning up late comments on PR529 #539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pmauduit, I've reverted bc7cf9b from #529 as it breaks the integration tests. We need to figure out why the gateway's base path sent as x-forwarded-path is duplicated in the getcaps responses. Meanwhile, I've created a fix-missing-gwc-local-paths-380 branch in the main repo with the original commit and the one from this pr, both on top of the latest main. Feel free to force-reset your branch for this pr and re-purpose it to implement #380 (re-opened). |
|
Closing this one, the commit is already on the top of the branch you created anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cleaning up the previous PR, after having reviewing myself.
See comments on the former PR #529.