Fix RepositoryCatalogFacadeImpl's query of PublishedInfo.class #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The webui layer preview page, and possibly other code paths, lead to querying the `PublishedInfo` super interface for `LayerInfo` and `LayerGroupInfo`. These queries must be delegated to the layer and layer group queries. The `DefaultCatalogFacade` in GeoServer does it and builds an in-memory list of the results. Our `RepositoryCatalogFacadeImpl` does it in a streaming fashion, but it wasn't respecting the limits, resulting in wrong results for the layer preview page. Now it queries `LayerRepository` and `LayerGroupRepository`, and returns a merge-sorted stream. If the query does not specify a sort order, the `id` property is used to provide predictable order for the merge-sort algorithm. When the returned stream is closed, it'll close the two underlying streams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webui layer preview page, and possibly other code paths, lead to querying the
PublishedInfosuper interface forLayerInfoandLayerGroupInfo.These queries must be delegated to the layer and layer group queries. The
DefaultCatalogFacadein GeoServer does it and builds an in-memory list of the results.Our
RepositoryCatalogFacadeImpldoes it in a streaming fashion, but it wasn't respecting the limits, resulting in wrong results for the layer preview page.Now it queries
LayerRepositoryandLayerGroupRepository, and returns a merge-sorted stream.If the query does not specify a sort order, the
idproperty is used to provide predictable order for the merge-sort algorithm.When the returned stream is closed, it'll close the two underlying streams.