Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all superfluously overridden methods from CatalogPlugin #389

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Remove all superfluously overridden methods from CatalogPlugin #389

merged 1 commit into from
Dec 7, 2023

Commits on Dec 7, 2023

  1. qa: Remove all superfluously overridden methods from CatalogPlugin 

    `CatalogPlugin` started by only implementing `Catalog` and hence
duplicated most of upstream's `CatalogImpl` functionality. Then it was
required for it to extend `CatalogImpl` instead, due to code in
GeoServer assuming the `Catalog` **is A** `CatalogImpl`, but the
overridden methods that did the same weren't removed.

This leaves `CatalogPlugin` much cleaner and it's easier to see how it
exactly differ from its superclass.
    @groldan
    groldan committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0e9bf4b View commit details
    Browse the repository at this point in the history