Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow EXTRA_JAVA_OPTS to be configured at runtime #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alir
Copy link
Contributor

@alir alir commented Nov 12, 2024

EXTRA_JAVA_OPTS is currently non-configurable and is added to CATALINA_OPTS at build time.

Users may want to configure the JVM heap values as well as some application properties at runtime, outside of the build process.

This change allows commands like the following to work:

docker run -p 8080:8080 -e "EXTRA_JAVA_OPTS=-Xmx2g" geoserver

This is picked up by Catalina when starting

image

and is also reflected in the GeoServer web console

image

@buehner
Copy link
Member

buehner commented Nov 20, 2024

Hi @alir . Thanks for the PR, but I do not understand the value your change adds as this feature is already available and working. Just try

docker run -it -p 80:8080 -e "EXTRA_JAVA_OPTS=-Xmx2g" docker.osgeo.org/geoserver:2.26.1 (so your change is not included) and it works out of the box.

In my eyes, there is no need to shift this to the startup script. In case you have a scenario where this is not working, please describe it and we can take this up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants