-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix convection issues when meteorology is Grell Freitas scheme #2523
base: dev/no-diff-to-benchmark
Are you sure you want to change the base?
Fix convection issues when meteorology is Grell Freitas scheme #2523
Conversation
GeosCore/convection_mod.F90
Outdated
ELSE | ||
PDOWN(NLAY) = 0 | ||
DO K = NLAY-1, 1, -1 | ||
PDOWN(K) = PDOWN(K+1) + DQRCU_MET(K+1) & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be: PDOWN(K) = PDOWN(K+1) + DQRCU_MET(K) * DELP(K) * G0_100 * 100e+0_fp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this to align with the pre-existing configuration:
geos-chem/GeosCore/convection_mod.F90
Lines 569 to 575 in bef56c6
! PFICU and PFLCU are on level edges | |
PFICU => State_Met%PFICU (I,J,2:State_Grid%NZ+1) ! Dwnwd flx of conv | |
! ice precip | |
! [kg/m2/s] | |
PFLCU => State_Met%PFLCU (I,J,2:State_Grid%NZ+1) ! Dwnwd flux of conv | |
! liquid precip | |
! [kg/m2/s] |
But if we look at where PDOWN is used, it seems to imply that PDOWN(K) to be the flux at the bottom of level K. So I think you are right, and we need to fix both RAS and GF's PDOWN.
Also, I have a question about:
geos-chem/GeosCore/convection_mod.F90
Lines 1101 to 1107 in bef56c6
! Check if... | |
! (1) there is precip coming into box (I,J,K) from (I,J,K+1) | |
! (2) there is re-evaporation happening in grid box (I,J,K) | |
! (3) there is species to re-evaporate | |
IF ( PDOWN(K+1) > 0 .and. & | |
REEVAPCN(K) > 0 .and. & | |
T0_SUM > 0 ) THEN |
Why is essential to have re-evaporation to have wash-out? Couldn't it be washout event without re-evaporation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Re-evaporation should not be a condition for washout, but I guess there will always be re-evaporation when the precip falls through drier air below the cloud base. Could you remove the re-evaporation condition and see how much difference it makes?
Let's fix PDOWN in RAS too. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Viral, please check the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yuanjianz, this looks great! One thing I could not tell for certain is whether we go through the entire routine even if there is no convection taking place in a column at the time step, or if there is an early exit somewhere if, say, the convective mass flux is zero throughout the column.
…eld definition change in Grell-Freitas convection
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
d130988
to
255a58d
Compare
… this PR goes into 14.5.1
I updated the PR description to include my contributions submitted via yuanjianz#1. |
Name and Institution (Required)
Yuanjian Zhang (WashU), Lizzie Lundgren (Harvard)
Describe the update
See discussion #1409
GEOS-IT and GEOS-FP after Jun 2020 switch to Grell Freitas convection from RAS. Some meteorology field definitions are changed. This update accommodates these fields to geos-chem convection.
Reported by @viral211 first:
@yuanjianz:
Changes include:
geoschem_config.yml
Input_Opt
logical for whether to reconstruct convective precipitation flux. This switch is set automatically during run-time to true for GEOS-IT, true for GEOS-FP if start date is June 1 2020 or later, and false for all other cases.Input_Opt
logical to use an alternative method in convection which bypasses use of PFLCU and PFICU when necessary. This fixes the zero convective precipitation and high cloud base in runs using GEOS-FP (>=01Jun2020) or GEOS-IT.Related convection fixes are also applicable to simulations using met-fields generated with RAS. These are submitted via separate PR #2573. Those updates will impact the GEOS-Chem benchmark.
Expected changes
Lower cloud base and restored washout in geos-chem convection driven by GEOS-IT and GEOS-FP after Jun 2020. This will not affect the GEOS-Chem benchmark which uses MERRA2.
Related Github Issue
#2469