Use SmallHeap also for the iterator-based nearest neighbour search and optimize its spill implementation. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d optimize its spill implementation.
adamreichold
force-pushed
the
use-small-heap-nn-iter
branch
from
58f3de8 to
3a9ac91
Compare
urschrei
approved these changes
Jan 22, 2024
|
@adamreichold Are you happy for this to merge so it can be included in the new release? |
|
Yes, I don't plan on changing anything here. (From measurements, I suspect we could increase the inline capacity from 32 to 64, but I only tested this using random trees and hence are not confident enough to commit to this yet.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rstar/CHANGELOG.mdif knowledge of this change could be valuable to users.