Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI as a precursor to enabling merge queues #143

Merged
merged 12 commits into from
Dec 20, 2023
Merged

Update CI as a precursor to enabling merge queues #143

merged 12 commits into from
Dec 20, 2023

Conversation

urschrei
Copy link
Member

See #142

  • I agree to follow the project's code of conduct.
  • I added an entry to rstar/CHANGELOG.md if knowledge of this change could be valuable to users.

@adamreichold
Copy link
Member

Did you configure the merge queue for squash merging? Otherwise, I would suggest manually squashing this PR before merging.

@urschrei
Copy link
Member Author

Did you configure the merge queue for squash merging? Otherwise, I would suggest manually squashing this PR before merging.

Configured to "squash and merge"

@urschrei urschrei added this pull request to the merge queue Dec 20, 2023
Merged via the queue into master with commit 54e7eb0 Dec 20, 2023
5 checks passed
@urschrei
Copy link
Member Author

Hum. That shouldn't have merged before the tests passed

@urschrei
Copy link
Member Author

Hum. That shouldn't have merged before the tests passed

Ah forgot to update setting with new ci check name. Now needs conclusion to pass before merging.

@adamreichold adamreichold deleted the update_ci branch December 24, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urschrei @adamreichold