Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time scale interpretation #162

Merged
merged 16 commits into from
Sep 19, 2023
Merged

fix time scale interpretation #162

merged 16 commits into from
Sep 19, 2023

Conversation

gwbres
Copy link
Collaborator

@gwbres gwbres commented Sep 8, 2023

This branch solves the following issue

Previous version of RINEX would identify most Epochs as UTC Epoch.
This is incorrect, as per RINEX specifications. Refer to the related issue for more information.

This branch proposes a fix that solves the Navigation and Observation Data cases which are the most complex.

To solve that, we use Epoch::from_str("YYYY-MM-DDTHH:MM:SS TS") which let us identify an Hifitime Epoch in almost any timescale.

This blocks any progress towards accurate positioning

Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres gwbres added this to the v1.0.0 milestone Sep 8, 2023
@gwbres gwbres self-assigned this Sep 8, 2023
@gwbres gwbres linked an issue Sep 8, 2023 that may be closed by this pull request
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres gwbres added enhancement New feature provided bug-fix Fix proposal labels Sep 18, 2023
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres gwbres marked this pull request as ready for review September 19, 2023 07:56
Signed-off-by: Guillaume W. Bres <[email protected]>
rinex/src/epoch/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres gwbres merged commit 929d302 into main Sep 19, 2023
1 check passed
@gwbres gwbres deleted the gnss-time branch September 19, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Fix proposal enhancement New feature provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoded Epoch type often has wrong timescale
2 participants