Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observation Data QC improvements #158

Merged
merged 20 commits into from
Sep 7, 2023
Merged

Observation Data QC improvements #158

merged 20 commits into from
Sep 7, 2023

Conversation

gwbres
Copy link
Collaborator

@gwbres gwbres commented Sep 7, 2023 •
edited
Loading

Improve Observation Data Quality analysis.

  • improve look and report rendering:
    • more table titles
    • improved spacing and styling
    • improved data reporting versus report classification method being used
  • Epoch reporting enhancement:
    • all types of anomalies are now reported
    • Problems like Power failures are reported (like "teqc" does)
    • Other types of events are reported
  • Simplified the Observation analyzer by using newly developed iterator
  • Preliminary work towards Receiver clock drift analysis like "teqc" does it: mainly needs an averaging method.
  • Developed new Iterators, for Observation Data analysis
    • Rinex::signal() to Iterate over Unique Signals that were identified
    • Rinex::code() to Iterate over Unique Signal Codes identified
  • Rinex::snr() to Iterate over signal SNR
  • introduced / improved SNR analysis

gwbres added 18 commits September 4, 2023 08:14
@gwbres
move deprecated file
5e056cc 
All qc analysis moved into a module.

Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
working on OBS Data QC
dedd15b 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
fix a couple of syntax issues
92a354c 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
fix a couple of syntax issues
a67ad8f 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
fix a couple of syntax issues
69d6589 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
working on averaging and derivation methods
b81468b 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
default clock window
fbb6f50 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
improving qc
e84992c 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
improving qc
169c8a2 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
improving qc
402044e 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
cli configuration
82330a8 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
improving qc
51ace43 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
qc doc
dc8e2c2 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
improving qc
e30993d 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
improving qc
f5d9505 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
improving qc
5971884 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
fix snr reporting
6bcc842 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
fix warnings
86f642d 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres gwbres added the enhancement New feature provided label Sep 7, 2023
@gwbres gwbres added this to the v1.0.0 milestone Sep 7, 2023
@gwbres gwbres self-assigned this Sep 7, 2023
@gwbres gwbres marked this pull request as draft September 7, 2023 08:37
gwbres
gwbres commented Sep 7, 2023
View reviewed changes
rinex/src/lib.rs Show resolved Hide resolved
gwbres
gwbres commented Sep 7, 2023
View reviewed changes
rinex/src/lib.rs Show resolved Hide resolved
rinex/src/lib.rs Show resolved Hide resolved
rinex/src/meteo/record.rs Show resolved Hide resolved
rinex/src/observation/mod.rs Show resolved Hide resolved
rinex/src/observation/record.rs Show resolved Hide resolved
@gwbres gwbres marked this pull request as ready for review September 7, 2023 09:45
larsnaesbye
larsnaesbye approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@larsnaesbye larsnaesbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and I'm excited about the QC advances!

@gwbres
Copy link
Collaborator Author

gwbres commented Sep 7, 2023

Looking good and I'm excited about the QC advances!

with this and the following contribution, we pretty much have all the basics "teqc" reports ;)

@gwbres gwbres merged commit be4b8b5 into main Sep 7, 2023
1 check passed
@larsnaesbye
Copy link
Collaborator

This is quite amazing. Next up I guess is to write a guide on how to replace tecq :-D

@larsnaesbye larsnaesbye deleted the obs-qc branch September 7, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsnaesbye larsnaesbye larsnaesbye approved these changes

@lnicola lnicola Awaiting requested review from lnicola

Assignees

@gwbres gwbres

Labels
enhancement New feature provided
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gwbres @larsnaesbye