Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test ecosystem #151

Merged
merged 8 commits into from
Aug 30, 2023
Merged

improve test ecosystem #151

merged 8 commits into from
Aug 30, 2023

Conversation

gwbres
Copy link
Collaborator

@gwbres gwbres commented Aug 29, 2023

  • fix Test compile fail #147
  • move rinex/tests within the crate (rinex/src/tests as a module)
  • ignore files generated by "doc rs"
  • use std::PathBuf more often

gwbres added 5 commits August 29, 2023 18:34
@gwbres
avoid generating one file, when building docs
3456a16 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
use std::pathbuf instead of strings
ef8ad77 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
use std::path more often
482ed2b 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
gitignore
30f1dd6 
Files are generated by doc.rs : simply ignore them, it's better
to have compelling examples than anything

Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
move test ecosystem within crate
41cb237 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres gwbres added the enhancement New feature provided label Aug 29, 2023
@gwbres gwbres added this to the v1.0.0 milestone Aug 29, 2023
@gwbres gwbres requested review from lnicola and larsnaesbye August 29, 2023 17:11
@gwbres gwbres self-assigned this Aug 29, 2023
@gwbres
cargo fmt
18dd73f 
Signed-off-by: Guillaume W. Bres <[email protected]>
lnicola
lnicola reviewed Aug 29, 2023
View reviewed changes
rinex/src/tests/merge.rs Outdated Show resolved Hide resolved
lnicola
lnicola reviewed Aug 29, 2023
View reviewed changes
rinex/src/tests/meteo.rs Outdated Show resolved Hide resolved
gwbres added 2 commits August 30, 2023 09:28
@gwbres
test/merge: rename 'test' module
abcf52f 
Signed-off-by: Guillaume W. Bres <[email protected]>
@gwbres
apply suggestions
5afb72a 
Signed-off-by: Guillaume W. Bres <[email protected]>
lnicola
lnicola approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now so you can merge, I'll be less responsive today.

@gwbres
Copy link
Collaborator Author

gwbres commented Aug 30, 2023

Thank you guys

@gwbres gwbres merged commit 1f9a7c4 into main Aug 30, 2023
1 check passed
@gwbres gwbres deleted the gh-fix-147 branch August 30, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsnaesbye larsnaesbye larsnaesbye approved these changes

@lnicola lnicola lnicola approved these changes

Assignees

@gwbres gwbres

Labels
enhancement New feature provided
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Test compile fail
3 participants
@gwbres @lnicola @larsnaesbye