Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow cumulative innerBoundaryIs tags on a polygon #59

Merged
merged 2 commits into from
Jan 2, 2024
Merged

fix: allow cumulative innerBoundaryIs tags on a polygon #59

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1f67d8
fix: allow cumulative innerBoundaryIs tags on a polygon
cfzimmerman Dec 31, 2023
8810f18
style: condense polygon innerBoundaryIs handler
cfzimmerman Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,10 @@ where
}
outer = outer_ring.remove(0);
}
b"innerBoundaryIs" => inner = self.read_boundary(b"innerBoundaryIs")?,
b"innerBoundaryIs" => {
let mut boundary = self.read_boundary(b"innerBoundaryIs")?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the intermediate variable or would this be fine?

inner.append(&mut self.read_boundary(b"innerBoundaryIs")?);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, thanks! Just made the change.

inner.append(&mut boundary);
}
b"altitudeMode" => {
altitude_mode = types::AltitudeMode::from_str(&self.read_str()?)?
}
Expand Down
Loading