Delete bors.toml in favor of GitHub merge queues #1037
Conversation
|
I just added the |
|
Let's hold off until we figure out what we're doing wrong with our settings. e.g. see georust/proj#169 |
We need a ci-status job that explicitly fails, rather than skips. As we discovered in georust/proj#179, the previous configuration would skip the aggregate "ci status" job if any of it's `needs` failed, which would result in the merge queue proceeding with the merge.
michaelkirk
force-pushed
the
frewsxcv-patch-1
branch
from
6f3a7f4 to
b44bd09
Compare
|
I've rebased and pushed up some commits to this branch (I hope that's OK!) Based on what we discovered in georust/proj#179, I updated our workflow to get merge queues functioning how we want. I also pushed up another commit with a failing test so we can double check that things are functioning as expected. If I get a 👍 we can click "merge when ready" and hopefully it will fail to merge from the failing test. Update: failing as expected -> |
|
Clicked "merged when ready"... Hopefully this will fail to merge, and then I can revert the failing test commit. |
michaelkirk
force-pushed
the
frewsxcv-patch-1
branch
from
b44bd09 to
f593fae
Compare
Cool, seems to be doing the right thing so far. It won't merge because of the failing check. Let me revert that problematic commit now. |
…cted" This reverts commit f593fae.
|
bors is dead, long live the merge queue. goodbye bors. 😢 |
CHANGES.mdif knowledge of this change could be valuable to users.